Skip to content

Fixing an issue with using show configuration within extensions #15766

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
codyrancher merged 3 commits into from
Nov 6, 2025
Merged

Fixing an issue with using show configuration within extensions #15766

codyrancher merged 3 commits into from
Nov 6, 2025

Conversation

@codyrancher
Copy link
Member

@codyrancher codyrancher commented Oct 28, 2025 •
edited
Loading

Summary

Fixes #15658

Technical notes summary

This is caused because the extension has copied an old version of the resource-class which doesn't include show configuration.
This will now check to see if it exists and if it doesn't it will use the latest definition and bind the resource to it.

Areas or cases that should be tested

Show configuration, show labels and annotations in the masthead.

Just a note, if you refresh the detail page the new detail page will not be rendered. I commented here rancher/kubewarden-ui#1333 (comment)

Areas which could experience regressions

Show configuration, show labels and annotations in the masthead.

Screenshot/Video

show-configuration-extension.mp4

Checklist

  • The PR is linked to an issue and the linked issue has a Milestone, or no issue is needed
  • The PR has a Milestone
  • The PR template has been filled out
  • The PR has been self reviewed
  • The PR has a reviewer assigned
  • The PR has automated tests or clear instructions for manual tests and the linked issue has appropriate QA labels, or tests are not needed
  • The PR has reviewed with UX and tested in light and dark mode, or there are no UX changes
  • The PR has been reviewed in terms of Accessibility
  • The PR has considered, and if applicable tested with, the three Global Roles Admin, Standard User and User Base

@rancher-ui-project-bot rancher-ui-project-bot bot added this to the v2.14.0 milestone Oct 28, 2025
@a110605 a110605 mentioned this pull request Nov 3, 2025
Closed
@codyrancher codyrancher force-pushed the show-configuration-extensions branch from adb1ba4 to 62de1e9 Compare November 4, 2025 16:56
@codyrancher codyrancher modified the milestones: v2.14.0, v2.13.0 Nov 4, 2025
@codyrancher codyrancher marked this pull request as ready for review November 4, 2025 19:10
@codyrancher codyrancher requested review from a110605 and cnotv November 4, 2025 19:10
@a110605
Copy link
Member

a110605 commented Nov 5, 2025

Tested with harvester standalone UI with this PR change is good.

But for Rancher harvester integration mode, using developer load harvester ui extension in extension page.

There is still error in console.

Screenshot 2025-11-05 at 11 45 21 AM

@codyrancher codyrancher force-pushed the show-configuration-extensions branch from 62de1e9 to ce9bcb5 Compare November 5, 2025 18:22
@codyrancher
Copy link
Member Author

codyrancher commented Nov 5, 2025 •
edited
Loading

Tested with harvester standalone UI with this PR change is good.

But for Rancher harvester integration mode, using developer load harvester ui extension in extension page.

There is still error in console.
Screenshot 2025-11-05 at 11 45 21 AM

I resolved this issue. It turns out that dynamic importing appears to be a problem in harvester and I just decided to work around it since it's not necessary for show configuration.

harvester-show.mp4

Just to preempt a possible concern. We don't show the config tab due to 63d2bcc#diff-65d145eecdf6d47052fa05eb10aad1c81026a913269c7b60ce8da494292dc0a9R41-R44 . We may want to revisit this but I don't think it needs to be changed now.

@codyrancher codyrancher force-pushed the show-configuration-extensions branch from ce9bcb5 to 2bacc73 Compare November 5, 2025 18:27
codyrancher
codyrancher commented Nov 5, 2025
View reviewed changes
shell/pkg/dynamic-importer.lib.js
Comment on lines +28 to +31
export function importDrawer(name) {
return () => undefined;
}

Copy link
Member Author

@codyrancher codyrancher Nov 5, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This doesn't impact anything in harvester. This is necessary if we want dynamic importing to work in the future.

@codyrancher codyrancher force-pushed the show-configuration-extensions branch from 2bacc73 to 34ac80c Compare November 5, 2025 20:08
codyrancher
codyrancher commented Nov 5, 2025
View reviewed changes
shell/components/Drawer/Chrome.vue
Copy link
Member Author

@codyrancher codyrancher Nov 5, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All the changes like this are to fix issues I saw in CI.
image

It appears that we have some webpack issues in some extensions which are treated differently in other as well as dashboard.

a110605
a110605 approved these changes Nov 6, 2025
View reviewed changes
Copy link
Member

@a110605 a110605 left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested locally with harvester standalone and rancher integration mode.
Show configuration button work well on both modes. Thanks for the fix.

fixed_show_config.mov

@codyrancher codyrancher merged commit 9ffcaff into rancher:master Nov 6, 2025
60 of 62 checks passed
@codyrancher codyrancher deleted the show-configuration-extensions branch November 6, 2025 15:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@a110605 a110605 a110605 approved these changes

@cnotv cnotv Awaiting requested review from cnotv

Assignees

@codyrancher codyrancher

Labels

None yet

Projects

None yet

Milestone

v2.13.0

Development

Successfully merging this pull request may close these issues.

Show configuration displayed and not working

2 participants

@codyrancher @a110605